Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub DeployBuilder #220

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Pub DeployBuilder #220

merged 1 commit into from
Dec 18, 2024

Conversation

gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Dec 11, 2024 •
edited
Loading

This helper was public in casper node and consumed by crates that can build deploy easily. Would you please consider making it public ? Related to #212

@gRoussac gRoussac requested review from wojcik91 and zajko December 11, 2024 23:12
@zajko
Copy link

zajko commented Dec 17, 2024

hi @gRoussac
This is a valid request - just one thing, what's your use case? Do you require only DeployBuilder or do you want also the TransactionV1Builder available from casper-client-rs.

@zajko zajko merged commit 03303a5 into casper-ecosystem:feat-track-node-2.0 Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajko zajko zajko approved these changes

@wojcik91 wojcik91 Awaiting requested review from wojcik91

Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gRoussac @zajko @devendran-m